Embed: don't fail while querying sections with bad id #8084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The approach looks fine but it looks like we have a check for broad exceptions. |
humitos
approved these changes
May 3, 2021
| query_result = body_obj(f'#{element_id}') | ||
| if query_result: | ||
| break | ||
| except Exception: # noqa |
There was a problem hiding this comment.
Can we make the exception we catch here more specific?
There was a problem hiding this comment.
the exception comes from a third party package that is used from pyquery, I don't like having imports from packages that aren't listed in our requirements, also there may be more exceptions than the one reported, so we would still need to have a broader check. And, only the pyquery execution is inside the try block, so no need to scope it down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.