Improve contributing docs, take 2 #8113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocobennett
reviewed
Apr 19, 2021
| @@ -62,15 +62,26 @@ Set up your environment | |||
|
|
|||
| * go to http://localhost:9000/ (MinIO S3 storage backend) | |||
| * login as ``admin`` / ``password`` | |||
| * click "..." next to the bucket name and then "Edit Policy" | |||
| * give "Read Only" access on all the buckets (``static`` and ``media``) | |||
| * click "..." next to the ``static`` bucket name and then "Edit Policy" | |||
There was a problem hiding this comment.
These new instructions are very helpful! Thank you for doing this!
humitos
approved these changes
Apr 19, 2021
|
Thanks @humitos and @cocobennett for having a look! 🙌🏽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This should be ready to go, but at the moment I am not able to complete the steps because of a local error:(Edit: Figured it out, fix to follow)