Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Querysets: simplify project querysets #8154

Merged
merged 1 commit into from May 6, 2021
Merged

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented May 4, 2021

  • Introduce Project.objects.for_user.
    This is to replace the for_team_member method from .com
  • private isn't used in both sites, and usually what we call private is just the use of public passing a user.
  • Remove unused overrides.

@stsewd stsewd force-pushed the simplify-project-querysets branch 2 times, most recently from 9cd1726 to b78896c Compare May 4, 2021 01:15
- Introduce `Project.objects.for_user`.
  This is to replace the `for_team_member` method from .com.
- Remove unused overrides.
@stsewd stsewd force-pushed the simplify-project-querysets branch from b78896c to 8b04f53 Compare May 4, 2021 01:39
@stsewd stsewd requested a review from a team May 4, 2021 01:48
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

readthedocs/projects/querysets.py Show resolved Hide resolved
@stsewd stsewd merged commit 2ce3a5e into master May 6, 2021
@stsewd stsewd deleted the simplify-project-querysets branch May 6, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants