Search: refactor views #8157
Merged
Search: refactor views #8157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was extracted from #8149 to make it easy to review. - Separate this "shared" view into two classes, too many conditionals otherwise. - Remove unused `index` query param.
stsewd
commented
May 4, 2021
| results = [] | ||
| facets = {} | ||
|
|
||
| if user_input.query: |
There was a problem hiding this comment.
this whole block was moved to the base class.
stsewd
commented
May 4, 2021
| - q: search term | ||
| - version: version to filter by | ||
| - role_name: sphinx role to filter by |
There was a problem hiding this comment.
In the search tab we only search for files under that project, so no need to choose between serializes or to pass any other additional inputs
Co-authored-by: Eric Holscher <25510+ericholscher@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This was extracted from #8149
to make it easy to review.
otherwise.
indexquery param.No changes to the logic were made, there is another PR in .com to match these changes