Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Querysets: remove private and for_project #8158

Merged
merged 1 commit into from May 11, 2021
Merged

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented May 5, 2021

These aren't used, and I don't see them being used in the future.

  • private: there isn't a part of our code were we want to list
    all private versions, instead we may want to use public(user).
  • for_project: this was listing all versions from a project and its
    translation. Not sure were we would want that, but isn't used.

The private queryset from projects is being removed in #8154

This aren't used, and I don't see them being used in the future.

- private: there isn't a part of our code were we want to list
  all private versions, instead we may want to use `public(user)`.
- for_project: this was listing all versions from a project and its
  translation. Not sure were we would want that, but isn't used.
@stsewd stsewd requested a review from a team May 5, 2021 23:50
@stsewd stsewd merged commit 2bea654 into master May 11, 2021
@stsewd stsewd deleted the simplify-builds-querysets branch May 11, 2021 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants