Ads: don't load script if a project is marked as ad_free #8164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
force-pushed
the
dont-include-js-if-ad-free
branch
from
28eb78e
to
24f7f74
Compare
stsewd
commented
May 7, 2021
stsewd
force-pushed
the
dont-include-js-if-ad-free
branch
from
24f7f74
to
5f9464e
Compare
stsewd
force-pushed
the
dont-include-js-if-ad-free
branch
from
5f9464e
to
a1a9ab0
Compare
I'm fine with that. Overall, I'm not very concerned about it. One thing is that this will change a server-side check into a client-side check meaning that an astute person could fairly easily disable ads on their documentation. With that said, it's still probably fine. It's already partially a client-side check anyway so maybe this isn't really a big deal. |
davidfischer
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are passing this down from
readthedocs.org/readthedocs/doc_builder/backends/mkdocs.py
Line 250 in 2ce3a5e
We are also passing that from the api. So, I guess there is the question: if a user stops being gold and doesn't rebuild their docs they will be ad-free, are we ok with that?
closes #8161