QuerySets: refactor _add_user_repos #8182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get ready for sharing more code, mainly rename `_add_user_repos` to `_add_from_user_projects` and `_add_user_projects`. Stat accepting admin and member attributes, this aren't used here yet, but they will. I have removed some overrides that weren't needed or weren't overridden in .com.
ericholscher
approved these changes
May 24, 2021
| .. note:: | ||
|
|
||
| In .org all users are admin and member of a project. | ||
| This will change with organizations soon. |
| @@ -79,18 +79,6 @@ def test_subproject_queryset_attributes(self): | |||
| self.assertEqual(ChildRelatedProjectQuerySet.project_field, 'child') | |||
| self.assertTrue(ChildRelatedProjectQuerySet.use_for_related_fields) | |||
|
|
|||
| def test_subproject_queryset_as_manager_gets_correct_class(self): | |||
There was a problem hiding this comment.
Is it safe to delete this? We don't want to check that the subproject still gets the right class, just without the Base?
Co-authored-by: Eric Holscher <25510+ericholscher@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get ready for sharing more code,
mainly rename
_add_user_reposto_add_from_user_projectsand_add_user_projects.Start accepting admin and member attributes where needed,
these aren't used here yet, but they will.
I have removed some overrides that weren't needed or weren't overridden
in .com.
And for my next trick/PR, I'd try to move some overrides into .org :D