Footer: return well formed html

[stsewd]

We shouldn't use strong tags to surround a dd tag, use css instead.

Closes #7903

[stsewd]

noticed we are using rst- for the other selectors, not sure why, so I went with rtd-

[ericholscher]

I think the CSS for the footer is defined here: https://github.com/readthedocs/readthedocs.org/blob/master/readthedocs/core/static/core/css/badge_only.css

Which is built from here: https://github.com/readthedocs/sphinx_rtd_theme/blob/master/src/sass/badge_only.sass

But we should fix that and include this CSS as part of RTD, but we should put the class in the right place.

[stsewd]

Done readthedocs/sphinx_rtd_theme#1148, should I just copy that file here? or is it done with a script?

[ericholscher]

...no idea -- looks like it hasn't changed since 2018 :D

[ericholscher]

I'm sure there was a script at some point, but just manually copying it is probably fine.

[stsewd]

Hmm, I only see this file being included in our docs https://assets.readthedocs.org/static/css/readthedocs-doc-embed.css

https://github.com/readthedocs/readthedocs-sphinx-ext/blob/f47a64adbb8446238d36c1908ec62694fd7a5dc5/readthedocs_ext/readthedocs.py#L99-L112

https://github.com/readthedocs/readthedocs-sphinx-ext/blob/f47a64adbb8446238d36c1908ec62694fd7a5dc5/readthedocs_ext/readthedocs.py#L174-L174

https://github.com/readthedocs/readthedocs-sphinx-ext/blob/f47a64adbb8446238d36c1908ec62694fd7a5dc5/readthedocs_ext/_templates/readthedocs-insert.html.tmpl#L21-L21

In a mkdocs project both files are included (https://assets.readthedocs.org/static/css/badge_only.css)

https://rtd-mkdocs-test-project.readthedocs.io/en/readthedocs-1.0/

readthedocs.org/readthedocs/doc_builder/backends/mkdocs.py

Lines 169 to 172 in f4c0a21

	extra_css_list = [
	'%scss/badge_only.css' % static_url,
	'%scss/readthedocs-doc-embed.css' % static_url,
	]

So, looks like we need to include that change here after all p:

[ericholscher]

@stsewd badge_only is included on non-RTD theme docs, eg. https://pip.pypa.io/en/stable/

https://github.com/readthedocs/readthedocs-sphinx-ext/blob/f47a64adbb8446238d36c1908ec62694fd7a5dc5/readthedocs_ext/readthedocs.py#L88-L92

[ericholscher]

Created #8247

[ericholscher]

Footer change looks good, but should put the CSS in the right place.

[ericholscher]

I think the CSS for the footer is defined here: https://github.com/readthedocs/readthedocs.org/blob/master/readthedocs/core/static/core/css/badge_only.css

Which is built from here: https://github.com/readthedocs/sphinx_rtd_theme/blob/master/src/sass/badge_only.sass

But we should fix that and include this CSS as part of RTD, but we should put the class in the right place.

[ericholscher]

I feel like we shouldn't hold up this PR on the small CSS change. Let's open an issue to make this way more obvious, and merge this 👍