Proxito: don't require the middleware for proxied apis #8203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
None of these need the proxito request middleware (response is needed). The analytics api isn't listed because it depends on the unresolver, which depends on the proxito middleware.
stsewd
force-pushed
the
dont-require-middleware-on-proxied-apis
branch
from
01d944c
to
3877651
Compare
ericholscher
approved these changes
May 20, 2021
| @@ -424,7 +424,7 @@ def test_highest_version_without_tags(self): | |||
| class TestFooterPerformance(TestCase): | |||
| # The expected number of queries for generating the footer | |||
| # This shouldn't increase unless we modify the footer API | |||
| EXPECTED_QUERIES = 15 | |||
| EXPECTED_QUERIES = 12 | |||
| @@ -126,6 +126,13 @@ class ProxitoMiddleware(MiddlewareMixin): | |||
|
|
|||
| """The actual middleware we'll be using in prod.""" | |||
|
|
|||
| skip_views = ( | |||
There was a problem hiding this comment.
This could use a comment explaining why they can be skipped (basically what's in the PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of these need the proxito request middleware (response is needed).
The analytics api isn't listed because it depends on the unresolver,
which depends on the proxito middleware.