Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update sharing #8239

Merged
merged 5 commits into from Aug 4, 2021
Merged

Docs: update sharing #8239

merged 5 commits into from Aug 4, 2021

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Jun 7, 2021

This is to match the changes in .com about supporting per-version
sharing.

This is to match the changes in .com about supporting per-version
sharing.
@stale
Copy link

stale bot commented Jul 23, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Jul 23, 2021
@stsewd stsewd removed the Status: stale Issue will be considered inactive soon label Jul 26, 2021
@stsewd stsewd requested a review from a team August 4, 2021 00:17
@stsewd
Copy link
Member Author

stsewd commented Aug 4, 2021

The PR from .com was merged, this is ready for review now.

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

docs/commercial/sharing.rst Outdated Show resolved Hide resolved
docs/commercial/sharing.rst Outdated Show resolved Hide resolved
Co-authored-by: Eric Holscher <25510+ericholscher@users.noreply.github.com>
@stsewd stsewd enabled auto-merge (squash) August 4, 2021 17:20
@stsewd stsewd merged commit 15a1896 into master Aug 4, 2021
@stsewd stsewd deleted the update-docs-sharing branch August 4, 2021 17:29
add an expiration date and a *Description* so you remember who you're sharing it with.
* Click *Share!* to create.
* Check ``Allow access to all versions?`` if you want to grant access to all versions,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we use :guilabel: here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants