Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove video from our Sphinx quickstart. #8246

Merged
merged 1 commit into from Jun 8, 2021
Merged

Remove video from our Sphinx quickstart. #8246

merged 1 commit into from Jun 8, 2021

Conversation

ericholscher
Copy link
Member

It's super out of date,
and doesn't show markdown, etc.

@ericholscher
Remove video from our Sphinx quickstart.
333b36c 
It's super out of date,
and doesn't show markdown, etc.
@ericholscher ericholscher requested a review from a team June 8, 2021 18:18
astrojuanlu
astrojuanlu approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, and I've been told it's a bit intimidating and long-ish too. +1

@ericholscher ericholscher merged commit fe6b24c into master Jun 8, 2021
3 checks passed
@ericholscher ericholscher deleted the remove-video branch June 8, 2021 18:55
humitos
humitos approved these changes Jun 8, 2021
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

@astrojuanlu astrojuanlu astrojuanlu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ericholscher @humitos @astrojuanlu