Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use email from DEFAULT_FROM_EMAIL to contact users #8344

Merged
merged 1 commit into from Jul 13, 2021
Merged

Use email from DEFAULT_FROM_EMAIL to contact users #8344

merged 1 commit into from Jul 13, 2021

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Jul 13, 2021

This setting includes the name, not just the email. We may want to change this value in our ops repos.

@stsewd
Use email from DEFAULT_FROM_EMAIL to contact users
bf37dd7 
We may want to change this value in our ops repos.
@stsewd stsewd requested a review from ericholscher July 13, 2021 22:17
ericholscher
ericholscher approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that this is sending mail in the task instead of in a celery task. That's probably fine for small sends, but we probably want to run it in celery for larger sends eventually.

@stsewd stsewd merged commit 21bcb57 into master Jul 13, 2021
@stsewd stsewd deleted the use-default-email branch July 13, 2021 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stsewd @ericholscher