Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cookies from cross site requests to avoid problems with iframes #8422

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Aug 17, 2021

No description provided.

@stsewd stsewd force-pushed the change-cookie-for-subomains branch from 4409001 to cca7979 Compare August 17, 2021 19:05
@ericholscher ericholscher added the PR: hotfix Pull request applied as hotfix to release label Aug 17, 2021
@stsewd stsewd merged commit 17303f2 into master Aug 17, 2021
@stsewd stsewd deleted the change-cookie-for-subomains branch August 17, 2021 21:14
@humitos
Copy link
Member

humitos commented Aug 18, 2021

Shouldn't we have a validatehttp test case for this? I'd like to prevent changing this again "to make it better" and realize that we broke something again. In particular, because there are many cases that we don't have in mind when making these changes and we all feel that it's for the better. A test breaking with a comment about the case it's covering, at least will make us to have another conversation at deploy time 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: hotfix Pull request applied as hotfix to release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants