Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try out codeowners #8429

Merged
merged 2 commits into from
Aug 19, 2021
Merged

Try out codeowners #8429

merged 2 commits into from
Aug 19, 2021

Conversation

agjohnson
Copy link
Contributor

I just learned about this feature. We can apparently default who to
delegate review to.

https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/creating-a-repository-on-github/about-code-owners

Code owners are automatically requested for review when someone opens a pull request that modifies code that they own.

I just learned about this feature. We can apparently default who to
delegate review to.

https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/creating-a-repository-on-github/about-code-owners

> Code owners are automatically requested for review when someone opens a pull request that modifies code that they own.
@agjohnson agjohnson requested a review from a team August 18, 2021 20:21
@stsewd
Copy link
Member

stsewd commented Aug 18, 2021

Think we can try to scope this down a little, like readthedocs/ @readthedocs/backend. I mean, I'm fine with asking review on any other file, but you and Eric are on those groups as well.

@agjohnson
Copy link
Contributor Author

Makes sense, I'll try default to backend for everything to test then. I could see us getting pretty granular with review if this works well.

Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. We could add other teams as well, like docs/* @readthedocs/advocacy for example. I read that this is just a test for now, but I think it will work.

@agjohnson
Copy link
Contributor Author

Or dockerfiles/* @humitos 😉

@agjohnson agjohnson merged commit 92f6224 into master Aug 19, 2021
@agjohnson agjohnson deleted the agj/try-codeowners branch August 19, 2021 17:34
@humitos
Copy link
Member

humitos commented Aug 19, 2021

Sold!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants