Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact users: pass user and domain in the context #8430

Merged
merged 3 commits into from Sep 1, 2021
Merged

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Aug 18, 2021

This also makes of the base template from email/common (they are already overridden in .com)

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Dear user...
Dear {{ user.firstname }},

Greetings from {{ domain }}.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bad example :) We probably want the brand, not the domain itself.

@stsewd stsewd enabled auto-merge (squash) September 1, 2021 14:50
@stsewd stsewd merged commit 2af4580 into master Sep 1, 2021
@stsewd stsewd deleted the use-templates branch September 1, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants