Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Team page #8441

Merged
merged 7 commits into from Sep 1, 2021
Merged

Rework Team page #8441

merged 7 commits into from Sep 1, 2021

Conversation

astrojuanlu
Copy link
Contributor

Finally, I updated the Team page to better reflect the reality 馃帀

  • Alignment with newly-created GitHub teams (Backend, Frontend, Avocacy, Ops)
  • Update company figures
  • Remove text inviting people to join to focus more on the core teams
  • Add avatars

Happy to read comments about my implementation of the avatars. I have no idea why, the HTML table has uneven column widths. I added a custom class in case @readthedocs/frontend can lend a hand shrinking the columns to the content.

On the other hand, I hardcoded the avatar URLs rather than requesting them using a REST API, because I don't think they will change much and also this doesn't require any JavaScript or complex Sphinx logic.

And finally, I wanted the substitution to be a figure so I could include the name below, but I couldn't make it work. .. figure needs a blank line before the caption text, which does not get on well with the substitution syntax.

Screenshot 2021-08-24 at 17-01-00 Read the Docs Team 鈥 Read the Docs 5 23 2 documentation

@astrojuanlu
Copy link
Contributor Author

@astrojuanlu astrojuanlu requested review from a team August 24, 2021 15:05
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a fine start. I think the pictures being repeated in each section is a bit odd though. I think probably doing a "core team" at the top with everyone and their pictures, and then just a listing of the teams & membership below without pics is probably better.

We should also put a bit more context around being paid and how we're funded in the top of this page. Right now it feels like a roster, but without much context as to the fact that we're all working full-time and paid. We should also have a section for contributors, where we at least acknowledge all the work other folks have done.

docs/team.rst Outdated Show resolved Hide resolved
@astrojuanlu
Copy link
Contributor Author

Good points. @humitos also informally hinted that the repeated pictures could be improved. Will iterate from here.

@astrojuanlu
Copy link
Contributor Author

I simplified the Team page a whole bunch, putting the pictures only once in a roster, listing the teams in bullet points, and clearly separating the Core Team from External Contributors.

@ericholscher I took the liberty of highlighting the work of two external contributors in particular, although I feel I'm missing the work of a lot of people in the past as well. Let me know what you think.

@astrojuanlu astrojuanlu requested review from ericholscher and a team August 31, 2021 14:58
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a much better change! A few small edits, and I think we're there 馃憤

docs/team.rst Outdated Show resolved Hide resolved
docs/team.rst Show resolved Hide resolved
astrojuanlu and others added 2 commits September 1, 2021 08:50
Co-authored-by: Eric Holscher <25510+ericholscher@users.noreply.github.com>
@astrojuanlu
Copy link
Contributor Author

Done with the last round of comments 鉁旓笍

@nienn had some excellent feedback about the appearance of the table. I think it would be a good opportunity to get her to do the CSS changes, so we can defer that to a future PR.

@ericholscher
Copy link
Member

@nienn had some excellent feedback about the appearance of the table. I think it would be a good opportunity to get her to do the CSS changes, so we can defer that to a future PR.

Where did this happen? I don't see it in the PR.

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 馃挴

It really is an important job,
and we'd love to have it be more geographically distributed.
============================ ============================
|eric| Eric Holscher |anthony| Anthony Johnson
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason our 2 names appear bolded? Not sure if that's just a rendering weirdness, or some markup I don't see.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The heading of the table I think? This is what the developer tools say:

.rst-content table.docutils thead th,
.rst-content table.field-list thead th,
.wy-table thead th {
 font-weight:700;
 border-bottom:2px solid #e1e4e5
}

I noticed it but considered it a nice "accident" since you're both in "all teams", founders, and c-level :)

@nienn
Copy link
Contributor

nienn commented Sep 1, 2021

@nienn had some excellent feedback about the appearance of the table. I think it would be a good opportunity to get her to do the CSS changes, so we can defer that to a future PR.

Where did this happen? I don't see it in the PR.

It was a discussion in Slack. I was asking @astrojuanlu feedback on an idea for adding a custom css file to these docs.
I hope to move the discussion here, into a new PR, as soon as I'm up and running with the .org project.

@astrojuanlu astrojuanlu merged commit d5ba4cf into master Sep 1, 2021
@astrojuanlu astrojuanlu deleted the rework-team-page branch September 1, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants