Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add virtual env instructions to local installation #8488

Merged
merged 4 commits into from Sep 15, 2021

Conversation

astrojuanlu
Copy link
Contributor

Prompted by a conversation with @humitos

@astrojuanlu astrojuanlu requested review from humitos, nienn and a team September 14, 2021 12:10
@astrojuanlu
Copy link
Contributor Author

docs/development/docs.rst Outdated Show resolved Hide resolved
@nienn
Copy link
Contributor

nienn commented Sep 14, 2021

This is much better! 👍
Tested and all seems to work for me.

@humitos
Copy link
Member

humitos commented Sep 15, 2021

Does make sense to add the virtualenv creation to the "Install common requirements" as well in the installation guide at https://docs.readthedocs.io/en/latest/development/install.html#set-up-your-environment

@astrojuanlu
Copy link
Contributor Author

Thanks @humitos ! Will do right now

@astrojuanlu
Copy link
Contributor Author

astrojuanlu commented Sep 15, 2021

Well, on second thought, the virtual environment for https://docs.readthedocs.io/en/latest/development/install.html#set-up-your-environment is not that important, since it's only installing two applications used to orchestrate the rest:

https://github.com/readthedocs/common/blob/5eec3f61b7b0bb1ee39564bdf5d5a6239e8df964/dockerfiles/requirements.txt#L2-L3

Even the Python version is kind of irrelevant.

On the other hand, @nienn opened #8489, so we can continue the discussion about that part of the documentation there, to avoid conflicts.

@astrojuanlu astrojuanlu merged commit b632dae into master Sep 15, 2021
@astrojuanlu astrojuanlu deleted the venv-contribution branch September 15, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants