Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HistoricalRecords: add additional fields (ip and browser) #8490

merged 5 commits into from Sep 29, 2021


Copy link

@stsewd stsewd commented Sep 14, 2021

No description provided.

@stsewd stsewd requested review from ericholscher and a team September 14, 2021 20:11
Copy link

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Shouldn't we add a test to confirm that we are saving this data correctly?

readthedocs/core/ Show resolved Hide resolved
@stsewd stsewd requested a review from humitos September 15, 2021 18:20
Copy link
Member Author

stsewd commented Sep 29, 2021

Changed from GenericIPField to a plain Charfield to avoid the same problems we had with using an ip field on the audit models.

@stsewd stsewd enabled auto-merge (squash) September 29, 2021 19:45
@stsewd stsewd merged commit 02ebae2 into master Sep 29, 2021
@stsewd stsewd deleted the additional-history-fields branch September 29, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants