Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics: allow to download all data #8498

Merged
merged 9 commits into from Sep 29, 2021
Merged

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Sep 15, 2021

We are selling that we store this data in .com,
but by default we only show data from the last 30 days,
and users can't download this data.

We keep showing data from the last 30 days in the graphs,
but users can download all the data they are allowed to.

There is a PR in .com that overrides these classes.

I have also normalized the dates used for search and page views
to be the same in .org (90 days).

Screenshot 2021-09-15 at 16-44-30 Traffic Analytics Read the Docs

We are selling that we store this data in .com,
but by default we only show data from the last 30 days,
and users can't download this data.

We keep showing data from the last 30 days in the graphs,
but users can download all the data they are allowed to.

There is a PR in .com that overrides these classes.

I have also normalized the dates used for search and page views
to be the same in .org (90 days).
@stsewd stsewd requested review from ericholscher and a team September 15, 2021 21:51
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't do a full review yet, but I think it would be good to add prefixes to the filenames so the user know what data they contain. Besides, I think that all the numbers of days should be settings, so we can easily change them if we decide that we want to retain the data for more/less time in the future

readthedocs/analytics/tasks.py Outdated Show resolved Hide resolved
readthedocs/projects/views/private.py Outdated Show resolved Hide resolved
readthedocs/projects/views/private.py Outdated Show resolved Hide resolved
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with Manuel on using a setting here, and we also need to ensure that we're not deleting users data who are paying us to keep it longer.

readthedocs/analytics/tasks.py Outdated Show resolved Hide resolved
readthedocs/projects/utils.py Outdated Show resolved Hide resolved
readthedocs/projects/views/private.py Outdated Show resolved Hide resolved
@stsewd stsewd requested review from ericholscher, humitos and a team September 20, 2021 20:29
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great improvement, so let's get it shipped.

@stsewd stsewd enabled auto-merge (squash) September 29, 2021 19:13
@stsewd stsewd merged commit db11521 into master Sep 29, 2021
@stsewd stsewd deleted the allow-download-analytics-data branch September 29, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants