Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List default installed dependencies #8503

Merged
merged 3 commits into from
Sep 20, 2021
Merged

Conversation

astrojuanlu
Copy link
Contributor

Taken from #7859, but removing mentions to deprecation policies or supported versions. Therefore, just describing what we do at the moment.

Comes from #8473 (comment).

stsewd and others added 2 commits September 16, 2021 12:31
Co-authored-by: Juan Luis Cano Rodríguez <juanlu@readthedocs.org>
@astrojuanlu
Copy link
Contributor Author

@stsewd
Copy link
Member

stsewd commented Sep 16, 2021

I think we could move this to be a section of builds.rst

@astrojuanlu
Copy link
Contributor Author

That was my first idea actually. If there are no objections I'll make the change 👍🏽

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. I agree Builds is probably the right place for it. That page in particular needs a lot of changes, so I'd love to have a refactor there as we go to add this, but we can keep them separate tasks, so this doesn't get blocked again.

Edit: Looks like the Build page is better than I remember. I think the main thing is the "Understand whats goin on" is a bit dense, but it's probably fine for now.

@astrojuanlu
Copy link
Contributor Author

Moved this content to the "Build process" page, and merging!

@astrojuanlu astrojuanlu merged commit 90e1a88 into master Sep 20, 2021
@astrojuanlu astrojuanlu deleted the juanlu/document-default-tools branch September 20, 2021 14:04
@@ -299,7 +299,7 @@ This has several advantages:
- Some configurations are only available using the config file.

Read the Docs works without this configuration
by :doc:`making some decisions on your behalf </default-versions>`.
by :ref:`making some decisions on your behalf <default-versions>`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use :ref:`builds:Default versions of dependencies` instead of hardcoding the ref.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops, I'm not used to have section autolabeling. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants