Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLab integration: escape path #8525

Merged
merged 1 commit into from Oct 21, 2021
Merged

GitLab integration: escape path #8525

merged 1 commit into from Oct 21, 2021

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Sep 23, 2021

The path/namespace must be url-encoded.
https://docs.gitlab.com/ee/api/index.html#namespaced-path-encoding

We were assuming that only the / needed to be escape,
and that the namespace can't have more /.

But GitLab has subgroups, which is parsed as the username in our code.

@stsewd stsewd requested a review from a team September 23, 2021 20:42
The path/namespace must be url-encoded.
https://docs.gitlab.com/ee/api/index.html#namespaced-path-encoding

We were assuming that only the `/` needed to be escape,
and that the namespace can't have more `/`.

But GitLab has subgroups, which is parsed as the username in our code.
@stsewd stsewd merged commit 458ed61 into master Oct 21, 2021
@stsewd stsewd deleted the gitlab-correcly-encode-path branch October 21, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants