Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmbedAPIv3: proxy URLs to be available under /_/ #8540

Merged
merged 1 commit into from Sep 29, 2021

Conversation

humitos
Copy link
Member

@humitos humitos commented Sep 28, 2021

Follow the same pattern than with APIv2 to access EmbedAPI under <docs.domain.org>/_/api/v3/embed/

Follow the same pattern than with APIv2 to access EmbedAPI under `<docs.domain.org>/_/api/v3/embed/`
@humitos humitos requested a review from a team September 28, 2021 17:06

# DRF has BasicAuthentication and SessionAuthentication as default classes.
# We don't support neither in the community site.
authentication_classes = []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably makes sense to make this a Mixin if we're using it on all proxied API's.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! I opened an issue to track this #8542

@humitos humitos added the PR: hotfix Pull request applied as hotfix to release label Sep 28, 2021
@humitos humitos merged commit 9d2d1a2 into master Sep 29, 2021
@humitos humitos deleted the humitos/proxy-embed-v3-urls branch September 29, 2021 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: hotfix Pull request applied as hotfix to release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants