Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script tools cache: fix environment variables #8541

Merged
merged 1 commit into from Sep 30, 2021

Conversation

humitos
Copy link
Member

@humitos humitos commented Sep 28, 2021

AWS_REGION is required in production and --endpoint-url is not.
Besides, AWS_BUILD_TOOLS_BUCKET_NAME is required as well in production.

@humitos humitos requested a review from a team September 28, 2021 17:43
`AWS_REGION` is required in production and `--endpoint-url` is not.
Besides, `AWS_BUILD_TOOLS_BUCKET_NAME` is required as well in production.
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough.

@humitos humitos merged commit bbf0614 into master Sep 30, 2021
@humitos humitos deleted the humitos/script-tools-cache branch September 30, 2021 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants