Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes to asdf image upload script #8587

Merged
merged 2 commits into from
Oct 18, 2021

Conversation

humitos
Copy link
Member

@humitos humitos commented Oct 14, 2021

Expand the docstring to mention what are the exact commands required to compile and upload a new build tool version.

Expand the docstring to mention what are the exact commands required to compile
and upload a new build tool version.
@humitos humitos requested a review from a team October 14, 2021 12:50
Base automatically changed from fix-uploads to master October 14, 2021 20:01
# TOOL=python
# VERSION=3.10.0
#
# cd /home/docs/checkouts/readthedocs.org/scripts
# virtualenv venv
# source venv/bin/activate
# pip install awscli==1.20.34
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version of awscli wasn't installable when I ran this, as well.

Suggested change
# pip install awscli==1.20.34
# pip install awscli

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what may happen when you ran it. I prefer to have this pinned to avoid random failure here. I just re-ran these commands and everything worked.

scripts/compile_version_upload_s3.sh Show resolved Hide resolved
@humitos
Copy link
Member Author

humitos commented Oct 18, 2021

The failing check is unrelated and already fixed in master.

@humitos humitos merged commit e87b6c9 into master Oct 18, 2021
@humitos humitos deleted the humitos/upload-build-tool-commands branch October 18, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants