Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements pinning #8655

Merged
merged 4 commits into from Nov 8, 2021
Merged

Conversation

astrojuanlu
Copy link
Contributor

@astrojuanlu astrojuanlu requested a review from a team as a code owner November 8, 2021 21:35
@astrojuanlu astrojuanlu requested a review from a team November 8, 2021 21:37
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are examples, but looks like people are copying/pasting those exact versions

@astrojuanlu
Copy link
Contributor Author

@astrojuanlu astrojuanlu merged commit c1dfed1 into master Nov 8, 2021
@astrojuanlu astrojuanlu deleted the update-requirements-pinning branch November 8, 2021 23:02
@humitos
Copy link
Member

humitos commented Nov 9, 2021

These are examples, but looks like people are copying/pasting those exact versions

Yeah 😞 --we may need to add a generic note or something. We can't keep these dependencies updated every time a new version is released.

@humitos
Copy link
Member

humitos commented Nov 9, 2021

@astrojuanlu also, I understand that the author of the original comment wanted to add the pin for docutils in particular, not just updating the version's numbers. This PR does not address that.

@astrojuanlu
Copy link
Contributor Author

@humitos There were two options: pinning docutils, or upgrading Sphinx (that in recent times started pinning docutils). I opted for the latter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants