Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify how to pin the Sphinx version #8687

Merged
merged 3 commits into from Nov 17, 2021
Merged

Conversation

astrojuanlu
Copy link
Contributor

See #8679.

@astrojuanlu astrojuanlu requested a review from a team as a code owner November 17, 2021 09:57
@astrojuanlu
Copy link
Contributor Author

@astrojuanlu astrojuanlu requested a review from a team November 17, 2021 16:48
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Is a pinning dependencies feature doc perhaps something we should put on our roadmap? Or perhaps expanding just the poetry docs we've been discussing?

docs/config-file/v2.rst Show resolved Hide resolved
@astrojuanlu
Copy link
Contributor Author

Is a pinning dependencies feature doc perhaps something we should put on our roadmap? Or perhaps expanding just the poetry docs we've been discussing?

You mean a "how packaging works in Python"? That's an interesting can of worms... 😃

Now seriously, we can discuss having a guide on the topic. The current landscape of PEPs and tools seems confusing, but actually things are much easier these days than it used to be.

@astrojuanlu
Copy link
Contributor Author

Enabling auto-merge on this one

@astrojuanlu astrojuanlu merged commit e7a3a68 into master Nov 17, 2021
@astrojuanlu astrojuanlu deleted the clarify-sphinx-pin branch November 17, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants