Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Domain: make cname_target configurable #8728

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Nov 29, 2021

This is so we can share the same view with .com
when switching to CF.

The steps will require to only create a CNAME record,
the value of this record will be unique per-domain on .com,
and it will continue to be static on .org.

The are PRs on .com and -ext

This is so we can share the same view with .com
when switching to CF.

The steps will require to only create a CNAME record,
the value of this record will be unique per-domain on .com,
and it will continue to be static on .org.
@stsewd stsewd requested a review from a team as a code owner November 29, 2021 21:44
<p>
<strong>{% trans 'SSL certificate status' %}: </strong>
<span>{{ domain.domainssl.status }}</span>
</p>
{% if domain.domainssl.status == 'pending_validation' %}
<p class="help_text"><small>{% trans 'Did you setup a CNAME record in DNS pointing at "readthedocs.io"?' %}</small></p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less hard coding is 💯

@stsewd stsewd merged commit 0156289 into master Dec 1, 2021
@stsewd stsewd deleted the configurable-cname-target branch December 1, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants