Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always clear cache after each test #8737

Merged
merged 1 commit into from Dec 1, 2021
Merged

Always clear cache after each test #8737

merged 1 commit into from Dec 1, 2021

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Dec 1, 2021

There is an error when running tests on .com
due to a cached key somewhere.
Maybe there is missing a tearDown somewhere
or it's the result of a side effect when running these tests
with the settings from .com.

But in any case, I think just making this for each test
is better instead of trying to figureout where to put
a tearDown function.

Hopefully the impact in time isn't big.

There is an error when running tests on .com
due to a cached key somewhere.
Maybe there is missing a tearDown somewhere
or it's the result of a side effect when running these tests
with the settings from .com.

But in any case, I think just making this for each test
is better instead of trying to figureout where to put
a tearDown function.

Hopefully the impact in time isn't big.
@stsewd stsewd requested a review from a team as a code owner December 1, 2021 18:48
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little surprised Django/pytest doesn't already do this.

@stsewd stsewd merged commit 29e7cff into master Dec 1, 2021
@stsewd stsewd deleted the fix-tests branch December 1, 2021 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants