Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: remove old/outdated code #8793

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Cleanup: remove old/outdated code #8793

merged 1 commit into from
Jan 10, 2022

Conversation

humitos
Copy link
Member

@humitos humitos commented Jan 4, 2022

It seems wea re not using these views anymore, so I'm deleting them together
with their templates. Besides, I deleted some unused settings as well.

@humitos humitos requested a review from a team January 4, 2022 13:06
It seems wea re not using these views anymore, so I'm deleting them together
with their templates. Besides, I deleted some unused settings as well.
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still used the embed views on occasion to test something, but I haven't in a long while. Seems like hoverxref or some other place is a better place for a demo like this.

@ericholscher ericholscher merged commit acfc0d9 into master Jan 10, 2022
@ericholscher ericholscher deleted the humitos/cleanup branch January 10, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants