Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project to use Ubuntu 22.04 LTS #9010

Merged
merged 5 commits into from Apr 27, 2022
Merged

Conversation

humitos
Copy link
Member

@humitos humitos commented Mar 14, 2022

Ubuntu 22.04 LTS is not yet released, but it's already available to use. We can
start allowing testing this image internally before upgrading production
servers.

Also, note that the default Python version was upgraded from 3.8 to 3.10.

Related to #9009

@humitos humitos requested review from a team as code owners March 14, 2022 15:09
@humitos humitos added the Status: blocked Issue is blocked on another issue label Mar 15, 2022
@humitos
Copy link
Member Author

humitos commented Mar 15, 2022

This PR has to be merged after April 21, when Ubuntu 22.04 is released and it will be available on AWS as well.

@humitos humitos self-assigned this Mar 30, 2022
@humitos humitos removed the Status: blocked Issue is blocked on another issue label Apr 26, 2022
@humitos humitos force-pushed the humitos/ubuntu-22.04-for-servers branch from 23ebc0e to 6befcb4 Compare April 26, 2022 14:37
@humitos
Copy link
Member Author

humitos commented Apr 26, 2022

Hrm, it seems that tests are not running because it can install django-allauth since we are using an old version. We should upgrade it (see #9122) before upgrading Ubuntu/Python. There are other benefits mentioned in the issue as well.

However, I didn't hit this issue when building the AMI images for production with packer. It seems it's more related to tox's default setuptools than with another thing.

Ubuntu 22.04 LTS is not yet released, but it's already available to use. We can
start allowing testing this image internally before upgrading production
servers.

Also note that the default Python version was upgraded from 3.8 to 3.10.
@humitos humitos force-pushed the humitos/ubuntu-22.04-for-servers branch from f4e494f to 9b7d39b Compare April 27, 2022 10:33
@humitos humitos force-pushed the humitos/ubuntu-22.04-for-servers branch from 9b7d39b to 8fe4bea Compare April 27, 2022 10:34
@humitos
Copy link
Member Author

humitos commented Apr 27, 2022

  • ✅ All tests passed!
  • ✅ Production AMIs were built successfully!
  • ✅ Local Docker image was built correctly!

@ericholscher @agjohnson @stsewd we should be ready to merge this PR, test it for a week and use the new Ubuntu 22.04 LTS base on next deploy.

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks simple enough. I'm less worried about it locally as running in production, but overall we don't depend on system-level packages for much beyond Python.

@@ -6,7 +6,7 @@ orbs:
jobs:
tests:
docker:
- image: 'cimg/python:3.8'
- image: 'cimg/python:3.10'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting. We'll finally be on a mostly up to date version of Python :)

RUN sh -c 'echo "deb http://apt.postgresql.org/pub/repos/apt $(lsb_release -cs)-pgdg main" > /etc/apt/sources.list.d/pgdg.list'
RUN curl -s https://www.postgresql.org/media/keys/ACCC4CF8.asc | apt-key add -
RUN apt-get -y update
RUN apt-get -y install postgresql-client-12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ deleting hacky code.

@humitos humitos merged commit cac2489 into main Apr 27, 2022
@humitos humitos deleted the humitos/ubuntu-22.04-for-servers branch April 27, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants