Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: do not send VCS build status on specific exceptions #9049

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

humitos
Copy link
Member

@humitos humitos commented Mar 29, 2022

When the exception is an exception we know it does not require communicating the
VCS service about its state, we avoid sending the build status to the VCS
service.

This is currently used to avoid sending a "failure" (red cross) notification
when the build is marked as duplicated. In the future, it could also be used
when the build is auto-cancelled because a new commit on the same branch was
done (see #8961)

Closes #9040

@humitos humitos requested a review from a team as a code owner March 29, 2022 14:21
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

When the exception is an exception we know it does not require communicating the
VCS service about its state, we avoid sending the build status to the VCS
service.

This is currently used to avoid sending a "failure" (red cross) notification
when the build is marked as duplicated. In the future, it could also be used
when the build is auto-cancelled because a new commit on the same branch was
done (see #8961)

Closes #9040
@humitos humitos force-pushed the humitos/external-build-status branch from ca4b3c7 to cf5221f Compare March 30, 2022 14:44
@humitos humitos enabled auto-merge March 30, 2022 14:44
@humitos humitos merged commit f47d9e8 into main Mar 30, 2022
@humitos humitos deleted the humitos/external-build-status branch March 30, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Duplicate build sends GH PR status, showing failure until the first build finishes
2 participants