Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: remove old feature flags #9377

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Docs: remove old feature flags #9377

merged 1 commit into from
Jun 30, 2022

Conversation

humitos
Copy link
Member

@humitos humitos commented Jun 27, 2022

I'm removing these because we don't want users ask for them to use in their
projects. All of the ones removed can be achieved by using build.jobs.* config.

Closes #9290

I'm removing these because we don't want users ask for them to use in their
projects. All of the ones removed can be achieved by using `build.jobs.*` config.

Closes #9290
@humitos humitos requested a review from a team as a code owner June 27, 2022 10:55
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a half solution. Do we have a plan to actually migrate these users?

@humitos
Copy link
Member Author

humitos commented Jun 28, 2022

We don't have a plan. However, I'm not sure if it's a big deal:

In [3]: Feature.objects.get(feature_id=Feature.LIST_PACKAGES_INSTALLED_ENV).projects.count()
Out[3]: 9

In [4]: Feature.objects.get(feature_id=Feature.UPDATE_CONDA_STARTUP).projects.count()
Out[4]: 12

In [5]: Feature.objects.get(feature_id=Feature.PIP_ALWAYS_UPGRADE).projects.count()
Out[5]: 5

None of these features are "breaking changes". Even if we remove these projects from these features, they should continue building. Maybe the conda one break --we should probably tell them to migrate to mamba if we haven't already (some of them are in the Google Sheet with a PR open/merged).

I'm happy to send them an email saying that in 30 days this feature will be removed completely, tho

@ericholscher
Copy link
Member

I'm happy to send them an email saying that in 30 days this feature will be removed completely, tho

Yea, I'd like to see us doing this proactively. I really liked the approach we took previously with opening PR's on their repos as well. I think getting a really nice workflow for proactively migrating users will definitely help us do it more frequently. Perhaps something that @benjaoming could help with.

Copy link
Contributor

@benjaoming benjaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - would be nice to have this removed from the documentation.

@benjaoming
Copy link
Contributor

@ericholscher sounds like a good idea! Kind of like a "feature flag deprecation bounty". Added to our roadmap.

@humitos
Copy link
Member Author

humitos commented Jun 30, 2022

I'll merge this PR because we want to remove this from the docs as the first step. However, we should track the migration of users/deprecation of these features in another task.

@humitos humitos merged commit 634f85b into main Jun 30, 2022
@humitos humitos deleted the humitos/feature-flags branch June 30, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Migrate user-facing feature flags into the product
3 participants