Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set JQuery globals on main site #9877

Merged
merged 1 commit into from Jan 9, 2023
Merged

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Jan 9, 2023

I guess this is related to the jquery update from #9861, or maybe this line wasn't working and we were relying in something else?

Not sure why I didn't notice this before,
maybe my browser cache :(

Ref #9861

I guess this is related to the jquery update from #9861,
or maybe this line wasn't working and we were relying
in something else?

Not sure why I didn't notice this before,
maybe my browser cache :(

Ref #9861
@stsewd stsewd requested a review from a team as a code owner January 9, 2023 22:50
@stsewd stsewd requested a review from agjohnson January 9, 2023 22:50
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd that we didn't catch this in tests, but I guess none of our JS is integration tested.. 🙃

@stsewd stsewd merged commit 8048602 into main Jan 9, 2023
@stsewd stsewd deleted the fix-jquery-main-page branch January 9, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants