New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a styling for :guilabel: inline markup.
#279
Conversation
|
Thanks for the addition! In terms of styling, here's a few things:
|
|
Thanks for the feedback @agjohnson!
Some screenshots again, on my particular resolution these two words appear right underneath one another, so it's a good illustration for the border box size. |
|
Reviewed 1 of 5 files at r1, 4 of 4 files at r2. Comments from Reviewable |
|
@Makc37 I've resolved the conflicts with master. |
|
Seems like this can be merged with a rebase. @agjohnson any objection? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates look good, I just a noted on the color variable used.
| @@ -298,6 +298,15 @@ | |||
| @extend .fa-download | |||
| &:before | |||
| margin-right: 4px | |||
| .guilabel | |||
| border: 1px solid lighten($class-color, 25%) | |||
| background: lighten($class-color, 50%) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't piggy back off of class-color and should set it's own color, or use something more appropriate than class-color.
|
Fixed this in a new branch and merged. |


Fixes #262.
:guilabel:is a convenient way to hint that a particular action in a user interface is available, unfortunately in the RTD theme there is no styling for it, so the markup appears as plain text.