Change Lato font to webfont (version 2.015) #639
Conversation
sass/_theme_font_local.sass
Outdated
| @@ -12,27 +12,32 @@ | |||
|
|
|||
| @font-face | |||
| font-family: 'Lato' | |||
| font-style: normal | |||
| src: url('../fonts/Lato/lato-regular.eot') | |||
| src: url('../fonts/Lato/lato-regular.ttf') format('truetype'), url('../fonts/Lato/lato-regular.svg#latoregular') format('svg') | |||
There was a problem hiding this comment.
This didn't include the .woff version. As a result, I downloaded the TTF instead.
There was a problem hiding this comment.
Fixed in new commit
sass/_theme_font_local.sass
Outdated
|
|
||
| @font-face | ||
| font-family: 'Lato' | ||
| src: url('../fonts/Lato/lato-bolditalic.eot') | ||
| src: url('../fonts/Lato/lato-bolditalic.eot?#iefix') format('embedded-opentype'), url('../fonts/Lato/lato-bolditalic.woff2') format('woff2'), url('../fonts/Lato/lato-bolditalic.woff') format('woff'), url('../fonts/Lato/lato-bolditalic.ttf') format('truetype'), url('../fonts/Lato/lato-bolditalic.svg#latobold_italic') format('svg') |
There was a problem hiding this comment.
I don't believe we use bold and italic in the theme anywhere. Is that wrong? This will result in additional disk usage for no benefit although that isn't a huge deal. Regardless, I'd say we shouldn't include it unless there's a reason.
There was a problem hiding this comment.
It's not possible to express bolditalic in rst syntax directly, but there are situations where it can happen, like bold text in a caption (which is italic by default) or italic text in a table header (which is already bold by default):
.. list-table::
:header-rows: 1
* - header
- **bold header**
- *italic header*
* - cell
- **bold cell**
- *italic cell*is rendered as:
There was a problem hiding this comment.
It doesn't look like it gets downloaded unless it's needed so I think we're fine here.
|
Also, I believe these are slightly smaller than the ones we are using on .org. I will make a small PR to update the .org. |
You generated the woff(2) on .org from the original ttf right? The font files in this PR came from the original latofonts.com website. |
|
Do we want to prefer a locally installed version of the font if available? This can save the download, although the version the user has installed may differ from what we use. |
Ya. You did the right thing. I replaced the generated ones with the ones from latofonts.com in readthedocs/readthedocs.org#4093.
I don't think it is necessary. Only a few people will have it. |
|
We could reduce bandwidth further by splitting each font file into a latin and one or more non-latin subsets. Browsers that view documentation that only uses latin characters will download the small font file. Other subsets will be downloaded as needed. |
| @@ -33,5 +38,4 @@ | |||
| font-family: 'Roboto Slab' | |||
| font-style: normal | |||
| font-weight: 700 | |||
| src: url('../fonts/RobotoSlab/roboto-slab-v7-bold.eot') | |||
| src: url('../fonts/RobotoSlab/roboto-slab-v7-bold.eot?#iefix') format('embedded-opentype'), url('../fonts/RobotoSlab/roboto-slab-v7-bold.woff2') format('woff2'), url('../fonts/RobotoSlab/roboto-slab-v7-bold.woff') format('woff'), url('../fonts/RobotoSlab/roboto-slab-v7-bold.ttf') format('truetype') | |||
| src: local('Roboto Slab Bold'), local('RobotoSlab-Bold'), url(../fonts/RobotoSlab-Bold.ttf) format('truetype') | |||
There was a problem hiding this comment.
Somehow this PR reverted this change. I'll fix it up.
This PR:
Related: readthedocs/readthedocs.org#3982, readthedocs/readthedocs.org#3564, #524 and #642