Fix line endings #709
Merged
Fix line endings #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will be normalized correctly on checkout
Blendify
approved these changes
Dec 18, 2018
|
I know I mentioned this is hard to test but I did test this after merging and it does appear to fix the problem. |
|
I sure hope this helps because I now have the original problem every time I switch branches that did not have this change yet. It should work itself out eventually, but maybe removing |
FranzForstmayr
pushed a commit
to FranzForstmayr/sphinx_rtd_theme
that referenced
this pull request
Apr 25, 2019
* Note that .bat has CRLF endings * Remove line endings on .bat It will be normalized correctly on checkout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately this is very hard to test but I believe this change will fix the issues with CRLF in the .bat file. Another possibility is simply to remove the line
* text eol=lfin.gitattributes.https://www.git-scm.com/docs/gitattributes
https://help.github.com/articles/dealing-with-line-endings/
Fixes #708.