Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope autodoc styling to .class and .data for Sphinx 2.0 #755

Merged
merged 3 commits into from Jul 4, 2019

Conversation

Projects
None yet
4 participants
@jessetan
Copy link
Contributor

commented Apr 28, 2019

Sphinx 2.0+ uses less table elements and more definition lists for layout. This causes styling for autodoc, class etc. to interfere with other layout.
This PR scopes the styling to definition lists in .class or .data, which is all we use in the demo docs. There may be more examples in the wild, but at least this fixes glossaries.

The diff looks larger than it is, only changes to the SASS is an added comment and two classes. Rest of the changes is due to added indentation.

Fixes #752. Affects #741, but does not fix it

@jessetan jessetan requested a review from Blendify Apr 28, 2019

@jessetan jessetan requested review from agjohnson and davidfischer Jun 26, 2019

@ericholscher ericholscher requested a review from readthedocs/core Jun 26, 2019

@ericholscher

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

Would be good to have a review here @davidfischer or @agjohnson 👍

@davidfischer
Copy link
Contributor

left a comment

When reviewing without whitespace this is a pretty small change. LGTM

@jessetan jessetan merged commit f237820 into master Jul 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jessetan jessetan deleted the fix-752 branch Jul 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.