Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run webpack js through Prettier JS formatter #807

Merged
merged 2 commits into from Aug 22, 2019

Conversation

@agjohnson
Copy link
Collaborator

commented Jul 26, 2019

Uses Prettier with no options. I'm fine accepting this as the default
style for our Javascript and autoformatting src/js/*.js as well. I left
those changes out for now.

Run webpack js through Prettier JS formatter
Uses Prettier with no options. I'm fine accepting this as the default
style for our Javascript and autoformatting src/js/*.js as well. I left
those changes out for now.
agjohnson added a commit that referenced this pull request Jul 26, 2019
Fix a number of issues with Webpack
A few of these squeezed by QA and testing:

* badge_only.css was copied to the static output path, it wasn't
  actually building it seems. Added second entry for this to make it
  easier.
* jQuery was not being treated as an external library and was vendored
  into our JS bundle!
* Having the fonts in a relative path from CSS ('../fonts'), causes CORS
  issues. Moved `/fonts` to `/sphinx_rtd_theme/static/css/fonts` essentially
* The dev server wasn't compiling assets consistently for me, tuned it hopefully

Requires #807

@agjohnson agjohnson requested a review from readthedocs/theme-committers Jul 26, 2019

@jessetan
Copy link
Contributor

left a comment

This is just formatting, so LGTM

@agjohnson agjohnson merged commit feb0beb into master Aug 22, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.