Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webpack commands into setup.py #809

Merged
merged 8 commits into from Oct 3, 2019

Conversation

@agjohnson
Copy link
Collaborator

commented Jul 26, 2019

This is a POC that shows building webpack through standard setup.py
commands. Any call to setup.py build or bdist or sdist will
trigger a Webpack build of the assets first. A non-zero exit code will
halt the process.

Also, moved the npm run dev command, which here is python setup.py watch, though there is perhaps something better here. There is already
python setup.py develop, which has a separate function, so I don't
want to collide there.

Example output here:
https://gist.github.com/agjohnson/cdaab364fe598daa7f3bef750cfb84dd

Refs #797

This is a POC that shows building webpack through standard `setup.py`
commands. Any call to `setup.py build` or `bdist` or `sdist` will
trigger a Webpack build of the assets first. A non-zero exit code will
halt the process.

Also, moved the `npm run dev` command, which here is `python setup.py
watch`, though there is perhaps something better here. There is already
`python setup.py develop`, which has a separate function, so I don't
want to collide there.

Example output here:
https://gist.github.com/agjohnson/cdaab364fe598daa7f3bef750cfb84dd

Refs #797
agjohnson added 4 commits Jul 29, 2019
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
agjohnson and others added 2 commits Aug 22, 2019
Co-Authored-By: Jesse Tan <jessetan@users.noreply.github.com>
Co-Authored-By: Jesse Tan <jessetan@users.noreply.github.com>
@jessetan jessetan referenced this pull request Oct 3, 2019
@agjohnson agjohnson merged commit ddf840c into master Oct 3, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@agjohnson agjohnson deleted the agj/setup-webpack-commands branch Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.