Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow select on code block shell prefixes #845

Merged
merged 4 commits into from Nov 11, 2019
Merged

Conversation

@Blendify
Copy link
Contributor

Blendify commented Oct 22, 2019

No description provided.

Copy link
Collaborator

agjohnson left a comment

Needs some fixes, however this also does not resolve #787. #787 is about the code block contrast being too low.

// Do not allow selection of code block prompts
div.highlight .gp
user-select: none;
pointer-events: none;

This comment has been minimized.

Copy link
@agjohnson

agjohnson Oct 24, 2019

Collaborator

This won't compile I believe, due to the semicolons. Is .gp class the leading # and %?

This comment has been minimized.

Copy link
@jessetan

jessetan Oct 25, 2019

Contributor

Good point, I was confused by this. The semicolons have a red background, probably because GitHub sees that it is invalid syntax in SASS (would be valid for CSS).
I mistook the red background for a git diff with characters that were removed.

Please remove the semicolons.

.gp stands for Generic.Prompt:

Marks the token value as command prompt (e.g. bash lexer).

(from http://pygments.org/docs/tokens/)

@agjohnson agjohnson changed the title Fix #787 Don't allow select on code block shell prefixes Oct 24, 2019
@agjohnson agjohnson mentioned this pull request Nov 2, 2019
@agjohnson agjohnson merged commit ab7d388 into master Nov 11, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@agjohnson agjohnson deleted the Blendify/fix-787 branch Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.