Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JS dependencies #867

Merged
merged 2 commits into from Jan 20, 2020
Merged

Update JS dependencies #867

merged 2 commits into from Jan 20, 2020

Conversation

@davidfischer
Copy link
Contributor

davidfischer commented Jan 14, 2020

This should fix the github JS vulns warning. I tested this by running npm run dev and npm run build to ensure that the JS still runs and compiles CSS/JS.

- This should fix the github JS vulns warning
@eine

This comment has been minimized.

Copy link

eine commented Jan 15, 2020

@davidfischer, it seems that matchdep is not used (imported/required) anywhere. Is it an actual dependency?

@davidfischer

This comment has been minimized.

Copy link
Contributor Author

davidfischer commented Jan 15, 2020

I didn't actually check whether it was needed. I'll check if it is and remove it otherwise. Thanks for the tip.

@davidfischer

This comment has been minimized.

Copy link
Contributor Author

davidfischer commented Jan 15, 2020

It is not used. I removed it!

@eine
eine approved these changes Jan 15, 2020
@eine

This comment has been minimized.

Copy link

eine commented Jan 15, 2020

Good! BTW, It would be handy to use david-dm and/or dependabot to keep dependencies up to date: devDependencies Status

@Blendify Blendify self-requested a review Jan 20, 2020
@Blendify Blendify merged commit 68a19ca into master Jan 20, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Blendify Blendify deleted the davidfischer/update-js-deps branch Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.