Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix CompositeItem not emitting blur events when unstable_virtual is true #858

Merged
merged 2 commits into from Apr 23, 2021

Conversation

diegohaz
Copy link
Member

If the user clicks on a CompositeItem element and then uses arrow keys to move to another item, the blur event is not fired on the first item.

This PR moves the logic of getting the previousElementRef to the onFocus event on the Composite component.

How to test?

See added test.

Does this PR introduce breaking changes?

No.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 23, 2021

Size Change: -5 B (0%)

Total Size: 257 kB

Filename Size Change
packages/reakit/dist/reakit.min.js 35.9 kB -5 B (0%)
ℹ️ View Unchanged
Filename Size Change
packages/reakit-playground/dist/reakit-playground.min.js 187 kB 0 B
packages/reakit-system-bootstrap/dist/reakit-system-bootstrap.min.js 19.1 kB 0 B
packages/reakit-system-palette/dist/reakit-system-palette.min.js 8.85 kB 0 B
packages/reakit-system/dist/reakit-system.min.js 2.45 kB 0 B
packages/reakit-utils/dist/reakit-utils.min.js 3.46 kB 0 B

compressed-size-action

@ariakit-bot
Copy link

ariakit-bot commented Apr 23, 2021

Deploy preview for reakit ready!

Built with commit 00e27a6

https://deploy-preview-858--reakit.netlify.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 00e27a6:

Sandbox Source
Reakit Configuration

@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #858 (00e27a6) into master (cd0c4df) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #858   +/-   ##
=======================================
  Coverage   94.88%   94.88%           
=======================================
  Files         231      231           
  Lines        3519     3519           
  Branches      958      959    +1     
=======================================
  Hits         3339     3339           
  Misses        179      179           
  Partials        1        1           
Impacted Files Coverage Δ
packages/reakit/src/Composite/Composite.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd0c4df...00e27a6. Read the comment docs.

@diegohaz diegohaz merged commit 56a86f5 into master Apr 23, 2021
@diegohaz diegohaz deleted the fix/composite-click-keyboard-blur-event branch April 23, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants