Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OSGi manifest headers #690

Merged
merged 1 commit into from Jul 27, 2019

Conversation

@io7m
Copy link
Contributor

commented Jul 27, 2019

This change moves to using the biz.aQute.bnd Gradle plugin to
produce OSGi-compatible manifests in jar files. Currently, only the
aeron-client, aeron-driver, and aeron-cluster modules have been updated
to provide OSGi metadata because the other modules are samples, tests,
or should never need to be visible inside an OSGi container. Care
has been taken to preserve the existing defined manifest fields
(Automatic-Module-Name, Implementation-Title, etc).

Note that until Agrona 1.0.4 is released (or at least a version containing
real-logic/agrona@49e769e),
the generated package imports for Agrona will be unversioned. This will
self-correct when Agrona 1.0.4+ is released and Aeron is updated to
point to the new version.

This change moves to using the biz.aQute.bnd Gradle plugin to
produce OSGi-compatible manifests in jar files. Currently, only the
aeron-client, aeron-driver, and aeron-cluster modules have been updated
to provide OSGi metadata because the other modules are samples, tests,
or should never need to be visible inside an OSGi container. Care
has been taken to preserve the existing defined manifest fields
(Automatic-Module-Name, Implementation-Title, etc).

Note that until Agrona 1.0.4 is released (or at least a version containing
real-logic/agrona@49e769e),
the generated package imports for Agrona will be unversioned. This will
self-correct when Agrona 1.0.4+ is released and Aeron is updated to
point to the new version.
@io7m

This comment has been minimized.

Copy link
Contributor Author

commented Jul 27, 2019

Please consider, if you have an Aeron release coming up, releasing Agrona first and then pointing Aeron at the new release. 😄

@mjpt777 mjpt777 merged commit f729649 into real-logic:master Jul 27, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mjpt777

This comment has been minimized.

Copy link
Contributor

commented Jul 27, 2019

Thanks. Will do. We will release Agrona early this week. I need it for some other changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.