CRC-32 #191
Merged
CRC-32 #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urther tests will not be affected
…onstructor private)
…irect ByteBuffer's contents
mjpt777
reviewed
Dec 24, 2019
| import java.lang.reflect.Method; | ||
| import java.util.zip.CRC32; | ||
|
|
||
| public final class CrcUtil |
There was a problem hiding this comment.
Better name may be Checksums.
mjpt777
reviewed
Dec 24, 2019
| manifest.attributes('Main-Class': 'org.openjdk.jmh.Main') | ||
| } | ||
|
|
||
| uploadArchives { |
mjpt777
reviewed
Dec 24, 2019
| * @param length of the data from which CRC-32 checksum should be computed. | ||
| * @return CRC-32 checksum. | ||
| */ | ||
| public static int crc32DirectByteBuffer(final int crc, final long address, final int offset, final int length) |
There was a problem hiding this comment.
crc32 is sufficient as a name. The address does not need to be for a direct ByteBuffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
CrcUtilclass that allows computing CRC-32 checksum from a direct ByteBuffer's content without modifying any of the ByteBuffer state.