From d2ec8f8a225808a1392872473f6e5e85b828056e Mon Sep 17 00:00:00 2001 From: Philippe Serreault Date: Fri, 19 May 2023 15:44:42 +0200 Subject: [PATCH] CppGenerator: operator<< take messages as const-ref (#939) Following commit 1973c86f84b190d5b2507786e6445970c390ea62, using generated operator<< would require a mutable ref message. This is unnecessary and can be problematic. Ex: using wrappers such as fmt::streamed ( https://fmt.dev/latest/api.html#std-ostream-support ) --- .../java/uk/co/real_logic/sbe/generation/cpp/CppGenerator.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/cpp/CppGenerator.java b/sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/cpp/CppGenerator.java index 1aed7b0df..482335b26 100755 --- a/sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/cpp/CppGenerator.java +++ b/sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/cpp/CppGenerator.java @@ -2564,7 +2564,7 @@ private void generateDisplay( new Formatter(sb).format("\n" + "template\n" + "friend std::basic_ostream & operator << (\n" + - " std::basic_ostream &builder, %1$s &_writer)\n" + + " std::basic_ostream &builder, const %1$s &_writer)\n" + "{\n" + " %1$s writer(\n" + " _writer.m_buffer,\n" +