Update 1.3 #28
Merged
Update 1.3 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Player movement and collision handling logic have been refactored. Previously, movement and collision checking logic were intertwined and complex. The updated version divides these concerns by first simulating player movement, then checking for collisions, and finally applying the movement if no collision is detected. Some unnecessary code snippets and unused imports were also removed. This improves code readability and maintainability. LDtkLoader.get() method was also renamed to LDtkLoader.getInstance() for consistency with other singleton classes.
|
LGTM! |
|
Approved |
# Conflicts: # .idea/workspace.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1.3 uses the new LDtk 1.4 schema and has fixed the movement (finaly!)