New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend SuperfluousDisableCommandRule to undefined rules #2348

Closed
fredpi opened this Issue Aug 8, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@fredpi
Copy link
Contributor

fredpi commented Aug 8, 2018

Currently, if I have a SwiftLint disable statement somewhere in my code, yet there isn't any rule triggering a violation, I get a warning about the superfluous statement (SuperfluousDisableCommandRule). I suggest to extend this behaviour to rules that aren't event defined, so if I'd write swiftlint:disable some_fancy_word, I would also get an error, even if some_fancy_word isn't a rule at all.

This would be helpful when dropping custom rules that once required for a few disable statements in-code. Currently, disable statements covering abandoned rules will rest in the code like dinosaurs 🦕.

@jpsim

This comment has been minimized.

Copy link
Collaborator

jpsim commented Jan 13, 2019

Fixed in #2504

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment