New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocorrect Cosmetic Rules #2353

Open
fabb opened this Issue Aug 10, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@fabb
Copy link

fabb commented Aug 10, 2018

Autocorrect is awesome (even more so when using File Watchers in AppCode and autocorrect a file on every save). There are some cosmetic (whitespace etc.) rules that would be cool if they got autocorrected as well:

closure_parameter_position
control_statement
implicit_getter
let_var_whitespace
modifier_order
multiline_function_chains
multiline_parameters
operator_whitespace

@realm-probot realm-probot bot added the O:User label Aug 10, 2018

biboran added a commit to biboran/SwiftLint that referenced this issue Dec 20, 2018

biboran added a commit to biboran/SwiftLint that referenced this issue Dec 20, 2018

biboran added a commit to biboran/SwiftLint that referenced this issue Dec 20, 2018

biboran added a commit to biboran/SwiftLint that referenced this issue Dec 20, 2018

biboran added a commit to biboran/SwiftLint that referenced this issue Dec 20, 2018

biboran added a commit to biboran/SwiftLint that referenced this issue Dec 20, 2018

biboran added a commit to biboran/SwiftLint that referenced this issue Dec 20, 2018

jpsim added a commit to biboran/SwiftLint that referenced this issue Dec 24, 2018

jpsim added a commit to biboran/SwiftLint that referenced this issue Dec 24, 2018

jpsim added a commit to biboran/SwiftLint that referenced this issue Dec 24, 2018

jpsim added a commit to biboran/SwiftLint that referenced this issue Dec 24, 2018

jpsim added a commit to biboran/SwiftLint that referenced this issue Dec 24, 2018

jpsim added a commit to biboran/SwiftLint that referenced this issue Dec 24, 2018

jpsim added a commit to biboran/SwiftLint that referenced this issue Dec 24, 2018

jpsim added a commit that referenced this issue Dec 24, 2018

Make modifier_order rule autocorrectable (#2521)
* #2353 - Move violating modifiers search to a private function

* #2353 - Add offset and length to the ModifierDescription

* #2353 - Make modifier_oder rule correctable

* #2353 - Add modifier_oder rule correction tests

* #2353 - Upadte the changelog

* #2353 - Add missing Foundation import

* #2353 - Fix linux tests

* Small edits to ModifierOrderRule and changelog entry

kimdv pushed a commit to kimdv/SwiftLint that referenced this issue Jan 6, 2019

Make modifier_order rule autocorrectable (realm#2521)
* realm#2353 - Move violating modifiers search to a private function

* realm#2353 - Add offset and length to the ModifierDescription

* realm#2353 - Make modifier_oder rule correctable

* realm#2353 - Add modifier_oder rule correction tests

* realm#2353 - Upadte the changelog

* realm#2353 - Add missing Foundation import

* realm#2353 - Fix linux tests

* Small edits to ModifierOrderRule and changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment