Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project doesn't work with Xcode 10.2 for contributors #2693

Closed
Dschee opened this issue Mar 27, 2019 · 5 comments

Comments

Projects
None yet
3 participants
@Dschee
Copy link
Collaborator

commented Mar 27, 2019

I just tried to rebase my PR #2296 onto the current master, but couldn't run the tests in order to update the Rules.md after rebasing using Xcode 10.2.

So I guessed that it's due to the dependencies not yet being Swift 5 compatible and ran carthage update --platform macos --cache-builds but that failed to build SourceKitten, which has a swift-5.0 branch soon to be merged, but seems not yet ready to be merged.

We should update the project to work with Xcode 10.2 shortly to allow contributors to use Xcode 10.2 and Swift 5. As a next step we could evalutate what new features of Swift 5 could be useful for SwiftLint (e.g. I suppose making use of SE-200 would make sense).

@marcelofabri

This comment has been minimized.

Copy link
Collaborator

commented Apr 1, 2019

As a next step we could evalutate what new features of Swift 5 could be useful for SwiftLint

We usually support building with the previous version of Swift for a while.

@Dschee

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 1, 2019

Makes sense. Does "while" mean something like "3 months" or more like "a year"? :)

In any case, we could still start elaborating what both the code simplification and performance improvements could be using Swift 5. Maybe some feature might be reasonable to be used right away using Swift version checks.

I might look into this sometime later this month myself unless someone else has time earlier.

@marcelofabri

This comment has been minimized.

Copy link
Collaborator

commented Apr 1, 2019

Makes sense. Does "while" mean something like "3 months" or more like "a year"? :)

I think it depends on how hard would it be to support both and what we'd be missing. Historically, I think it's closer to "a year" than "3 months", but also because it's been ok-ish to support the previous Swift version with #ifs and friends.

@jpsim

This comment has been minimized.

Copy link
Collaborator

commented Apr 7, 2019

For reference, we supported Swift 4.0/4.1 for just over two months after 4.2 was released and the first SwiftLint release requiring 4.2 to build. However, that was probably the fastest we did that in SwiftLint's history.

Also note that we've historically had proper support for new Swift versions within 1-2 weeks of the language's official release date (closer to 3 I think this time around). AND that we still supporting running SwiftLint on codebases as far back as Swift 3.0 even today (although it seems pretty safe to drop Swift 3 now if we want).

As you mentioned, there are PRs in flight for properly supporting Swift 5 for all our dependencies

I suspect the SourceKitten and Commandant releases will come in the next 2-4 days.

@marcelofabri

This comment has been minimized.

Copy link
Collaborator

commented Apr 29, 2019

This should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.