New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 4.1.0, 4.1.1 and 4.2.0 to Swift version detection #2143

Merged
merged 3 commits into from Apr 5, 2018

Conversation

Projects
None yet
4 participants
@norio-nomura
Collaborator

norio-nomura commented Apr 5, 2018

No description provided.

@norio-nomura

This comment has been minimized.

Collaborator

norio-nomura commented Apr 5, 2018

It seems https://cocoapods-specs.circleci.com/fetch-cocoapods-repo-from-s3.sh caused failure.
I'll rerun the job later.

@SwiftLintBot

This comment has been minimized.

SwiftLintBot commented Apr 5, 2018

12 Messages
📖 Linting Aerial with this PR took 0.43s vs 0.42s on master (2% slower)
📖 Linting Alamofire with this PR took 3.44s vs 3.44s on master (0% slower)
📖 Linting Firefox with this PR took 13.66s vs 13.81s on master (1% faster)
📖 Linting Kickstarter with this PR took 21.06s vs 21.31s on master (1% faster)
📖 Linting Moya with this PR took 2.01s vs 2.03s on master (0% faster)
📖 Linting Nimble with this PR took 1.92s vs 1.97s on master (2% faster)
📖 Linting Quick with this PR took 0.57s vs 0.58s on master (1% faster)
📖 Linting Realm with this PR took 3.89s vs 3.89s on master (0% slower)
📖 Linting SourceKitten with this PR took 1.23s vs 1.27s on master (3% faster)
📖 Linting Sourcery with this PR took 5.17s vs 5.37s on master (3% faster)
📖 Linting Swift with this PR took 17.38s vs 17.93s on master (3% faster)
📖 Linting WordPress with this PR took 17.18s vs 17.91s on master (4% faster)

Generated by 🚫 Danger

norio-nomura added some commits Apr 5, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Apr 5, 2018

Codecov Report

Merging #2143 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2143      +/-   ##
==========================================
+ Coverage   89.88%   89.89%   +<.01%     
==========================================
  Files         266      266              
  Lines       15375    15385      +10     
  Branches     1013     1013              
==========================================
+ Hits        13820    13830      +10     
  Misses       1535     1535              
  Partials       20       20
Impacted Files Coverage Δ
...ource/SwiftLintFramework/Models/SwiftVersion.swift 100% <ø> (ø) ⬆️
...sts/SwiftLintFrameworkTests/LinterCacheTests.swift 98.66% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af61971...2ab42cd. Read the comment docs.

@norio-nomura norio-nomura merged commit c501107 into master Apr 5, 2018

6 checks passed

ci/circleci: cocoapods Your tests passed on CircleCI!
Details
ci/circleci: linux_swift_4 Your tests passed on CircleCI!
Details
ci/circleci: osscheck Your tests passed on CircleCI!
Details
ci/circleci: swiftpm_4 Your tests passed on CircleCI!
Details
ci/circleci: tsan Your tests passed on CircleCI!
Details
ci/circleci: xcode_9 Your tests passed on CircleCI!
Details

@norio-nomura norio-nomura deleted the nn-detect-swift-4.1+ branch Apr 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment